Colour-coded nodes by year#11
Open
harise01 wants to merge 1 commit into
Open
Conversation
AJaccP
requested changes
Jun 6, 2026
| const { selectedCourse, highlightedSet } = useExplorerStore(); | ||
| const dimmed = selectedCourse !== null && !highlightedSet.has(data.code); | ||
|
|
||
| const year = data.code.charAt(5); |
Contributor
There was a problem hiding this comment.
PR looks good overall! One small robustness suggestion: right now this assumes that the "year" of the course will always be at index 5, which is true for subjects with 4 letter subject codes (e.g. COMP 1405).
However, if we expand to more subjects related to COMP, there are some 3 letter subject codes (e.g. BIT, IMD, NET etc.).
To always get the first digit in the course code, regardless of how long the subject code is, using regex would be better here. Something like:
data.code.match(/\d/)?.[0];
(Not 100% sure that's the right regex so I'd check it with some examples to confirm)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed and tested implementation of colour-coding nodes by year